Quantcast

[PATCH] xfstests: resolve symlinked devices to real paths

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] xfstests: resolve symlinked devices to real paths

Eric Sandeen-3
If you try running xfstests on lvm volumes which are symlinks,
it'll fail to run several tests because our _require_scratch
framework ultimately uses lstat not stat, and does not think
the lvm device (which is usually a symlink to a dm-X device)
is a block device.  Sigh.

Last try at this - just resolve any symlinked devicenames
into their realpath(3) in common.config.

This actually seems to work.

Signed-off-by: Eric Sandeen <[hidden email]>
---

diff --git a/common.config b/common.config
index 926846b..e5b2483 100644
--- a/common.config
+++ b/common.config
@@ -208,6 +208,15 @@ else
     known_hosts
 fi
 
+# Scripts just don't deal well with symlinked devices
+if [ -L $TEST_DEV ]; then
+        TEST_DEV=`src/realpath $TEST_DEV`
+fi
+
+if [ -L $SCRATCH_DEV ]; then
+        SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
+fi
+
 echo $TEST_DEV | grep -q ":" > /dev/null 2>&1
 if [ ! -b "$TEST_DEV" -a "$?" != "0" ]; then
     echo "common.config: Error: \$TEST_DEV ($TEST_DEV) is not a block device or a NFS filesystem"
diff --git a/src/Makefile b/src/Makefile
index 976133d..2399853 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -10,7 +10,8 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
  mmapcat append_reader append_writer dirperf metaperf \
  devzero feature alloc fault fstest t_access_root \
  godown resvtest writemod makeextents itrash rename \
- multi_open_unlink dmiperf unwritten_sync genhashnames t_holes
+ multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
+ realpath
 
 LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
  preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
diff --git a/src/realpath.c b/src/realpath.c
new file mode 100644
index 0000000..997b1aa
--- /dev/null
+++ b/src/realpath.c
@@ -0,0 +1,32 @@
+#include <limits.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+
+/*
+ * Simple wrapper around realpath(3) to get absolute path
+ * to a device name; many xfstests scripts don't cope well
+ * with symlinked devices due to differences in /proc/mounts,
+ * /etc/mtab, mount output, etc.
+ */
+
+int main(int argc, char *argv[])
+{
+ char path[PATH_MAX];
+ char resolved_path[PATH_MAX];
+
+ if (argc != 2) {
+ printf("Usage: %s <filename>\n", argv[0]);
+ return 1;
+ }
+
+ strncpy(path, argv[1], PATH_MAX-1);
+
+ if (!realpath(path, resolved_path)) {
+ perror("Failed to resolve path for %s");
+ return 1;
+ }
+
+ printf("%s\n", resolved_path);
+ return 0;
+}

_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: xfstests: resolve symlinked devices to real paths

Rich Johnston
On 06/08/2010 03:03 PM, Eric Sandeen wrote:

> If you try running xfstests on lvm volumes which are symlinks,
> it'll fail to run several tests because our _require_scratch
> framework ultimately uses lstat not stat, and does not think
> the lvm device (which is usually a symlink to a dm-X device)
> is a block device.  Sigh.
>
> Last try at this - just resolve any symlinked devicenames
> into their realpath(3) in common.config.
>
> This actually seems to work.
>
> Signed-off-by: Eric Sandeen <[hidden email]>
>
> ---
>
>
> diff --git a/common.config b/common.config
> index 926846b..e5b2483 100644
> --- a/common.config
> +++ b/common.config

Looks good

Reviewed-by: Rich Johnston <[hidden email]>

Eric,

This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests,
master branch, commit ID d5ea873f.

Thanks
--Rich

_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Satoru Takeuchi-2
Hi Rich, Eric

(2012/10/27 1:46), Rich Johnston wrote:

> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>> If you try running xfstests on lvm volumes which are symlinks,
>> it'll fail to run several tests because our _require_scratch
>> framework ultimately uses lstat not stat, and does not think
>> the lvm device (which is usually a symlink to a dm-X device)
>> is a block device.  Sigh.
>>
>> Last try at this - just resolve any symlinked devicenames
>> into their realpath(3) in common.config.
>>
>> This actually seems to work.
>>
>> Signed-off-by: Eric Sandeen <[hidden email]>
>>
>> ---
>>
>>
>> diff --git a/common.config b/common.config
>> index 926846b..e5b2483 100644
>> --- a/common.config
>> +++ b/common.config
>
> Looks good
>
> Reviewed-by: Rich Johnston <[hidden email]>
>
> Eric,
>
> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.

From: Satoru Takeuchi <[hidden email]>

Commit d5ea873f is not the same as the the following original Eric's patch.

http://oss.sgi.com/archives/xfs/2010-06/msg00080.html

It does not modify src/Makefile and realpath is never compiled.

In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
if $TEST_DEV or $SCRATCH_DEV are not defined.

Cc: Eric Sandeen <[hidden email]>
Cc: Rich Johnston <[hidden email]>
Signed-off-by: Satoru Takeuchi <[hidden email]>

---
 common.config |    4 ++--
 src/Makefile  |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common.config b/common.config
index 585b150..3240ee9 100644
--- a/common.config
+++ b/common.config
@@ -221,11 +221,11 @@ else
 fi
 
 # Scripts just don't deal well with symlinked devices
-if [ -L $TEST_DEV ]; then
+if [ -L "$TEST_DEV" ]; then
         TEST_DEV=`src/realpath $TEST_DEV`
 fi
 
-if [ -L $SCRATCH_DEV ]; then
+if [ -L "$SCRATCH_DEV" ]; then
         SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
 fi
 
diff --git a/src/Makefile b/src/Makefile
index f7362a2..9f7281d 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
        devzero feature alloc fault fstest t_access_root \
        godown resvtest writemod makeextents itrash rename \
        multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
-       t_mmap_writev
+       t_mmap_writev realpath
 
 LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
        preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
--
1.7.7.6


_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Wanlong Gao
On 11/19/2012 11:26 AM, sat wrote:

> Hi Rich, Eric
>
> (2012/10/27 1:46), Rich Johnston wrote:
>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>> If you try running xfstests on lvm volumes which are symlinks,
>>> it'll fail to run several tests because our _require_scratch
>>> framework ultimately uses lstat not stat, and does not think
>>> the lvm device (which is usually a symlink to a dm-X device)
>>> is a block device.  Sigh.
>>>
>>> Last try at this - just resolve any symlinked devicenames
>>> into their realpath(3) in common.config.
>>>
>>> This actually seems to work.
>>>
>>> Signed-off-by: Eric Sandeen <[hidden email]>
>>>
>>> ---
>>>
>>>
>>> diff --git a/common.config b/common.config
>>> index 926846b..e5b2483 100644
>>> --- a/common.config
>>> +++ b/common.config
>>
>> Looks good
>>
>> Reviewed-by: Rich Johnston <[hidden email]>
>>
>> Eric,
>>
>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>
> From: Satoru Takeuchi <[hidden email]>
>
> Commit d5ea873f is not the same as the the following original Eric's patch.
>
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>
> It does not modify src/Makefile and realpath is never compiled.
>
> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Cc: Eric Sandeen <[hidden email]>
> Cc: Rich Johnston <[hidden email]>
> Signed-off-by: Satoru Takeuchi <[hidden email]>

Reviewed-by: Wanlong Gao <[hidden email]>

>
> ---
>  common.config |    4 ++--
>  src/Makefile  |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/common.config b/common.config
> index 585b150..3240ee9 100644
> --- a/common.config
> +++ b/common.config
> @@ -221,11 +221,11 @@ else
>  fi
>  
>  # Scripts just don't deal well with symlinked devices
> -if [ -L $TEST_DEV ]; then
> +if [ -L "$TEST_DEV" ]; then
>          TEST_DEV=`src/realpath $TEST_DEV`
>  fi
>  
> -if [ -L $SCRATCH_DEV ]; then
> +if [ -L "$SCRATCH_DEV" ]; then
>          SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
>  fi
>  
> diff --git a/src/Makefile b/src/Makefile
> index f7362a2..9f7281d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
>         devzero feature alloc fault fstest t_access_root \
>         godown resvtest writemod makeextents itrash rename \
>         multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
> -       t_mmap_writev
> +       t_mmap_writev realpath
>  
>  LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
>         preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
>

_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Eric Sandeen-3
In reply to this post by Satoru Takeuchi-2
On 11/18/12 9:26 PM, sat wrote:

> Hi Rich, Eric
>
> (2012/10/27 1:46), Rich Johnston wrote:
>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>> If you try running xfstests on lvm volumes which are symlinks,
>>> it'll fail to run several tests because our _require_scratch
>>> framework ultimately uses lstat not stat, and does not think
>>> the lvm device (which is usually a symlink to a dm-X device)
>>> is a block device.  Sigh.
>>>
>>> Last try at this - just resolve any symlinked devicenames
>>> into their realpath(3) in common.config.
>>>
>>> This actually seems to work.
>>>
>>> Signed-off-by: Eric Sandeen <[hidden email]>
>>>
>>> ---
>>>
>>>
>>> diff --git a/common.config b/common.config
>>> index 926846b..e5b2483 100644
>>> --- a/common.config
>>> +++ b/common.config
>>
>> Looks good
>>
>> Reviewed-by: Rich Johnston <[hidden email]>
>>
>> Eric,
>>
>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>
> From: Satoru Takeuchi <[hidden email]>
>
> Commit d5ea873f is not the same as the the following original Eric's patch.
>
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>
> It does not modify src/Makefile and realpath is never compiled.

Yep, whoops.  Merge error . . .?

> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.

Well, I don't think ./check will get very far with an undefined TEST_DEV or
SCRATCH_DEV, but better this way, thanks.

Reviewed-by: Eric Sandeen <[hidden email]>

> Cc: Eric Sandeen <[hidden email]>
> Cc: Rich Johnston <[hidden email]>
> Signed-off-by: Satoru Takeuchi <[hidden email]>
>
> ---
>  common.config |    4 ++--
>  src/Makefile  |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/common.config b/common.config
> index 585b150..3240ee9 100644
> --- a/common.config
> +++ b/common.config
> @@ -221,11 +221,11 @@ else
>  fi
>  
>  # Scripts just don't deal well with symlinked devices
> -if [ -L $TEST_DEV ]; then
> +if [ -L "$TEST_DEV" ]; then
>          TEST_DEV=`src/realpath $TEST_DEV`
>  fi
>  
> -if [ -L $SCRATCH_DEV ]; then
> +if [ -L "$SCRATCH_DEV" ]; then
>          SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
>  fi
>  
> diff --git a/src/Makefile b/src/Makefile
> index f7362a2..9f7281d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
>         devzero feature alloc fault fstest t_access_root \
>         godown resvtest writemod makeextents itrash rename \
>         multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
> -       t_mmap_writev
> +       t_mmap_writev realpath
>  
>  LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
>         preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
>

_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Satoru Takeuchi-2
(2012/11/20 13:06), Eric Sandeen wrote:

> On 11/18/12 9:26 PM, sat wrote:
>> Hi Rich, Eric
>>
>> (2012/10/27 1:46), Rich Johnston wrote:
>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>> it'll fail to run several tests because our _require_scratch
>>>> framework ultimately uses lstat not stat, and does not think
>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>> is a block device.  Sigh.
>>>>
>>>> Last try at this - just resolve any symlinked devicenames
>>>> into their realpath(3) in common.config.
>>>>
>>>> This actually seems to work.
>>>>
>>>> Signed-off-by: Eric Sandeen <[hidden email]>
>>>>
>>>> ---
>>>>
>>>>
>>>> diff --git a/common.config b/common.config
>>>> index 926846b..e5b2483 100644
>>>> --- a/common.config
>>>> +++ b/common.config
>>>
>>> Looks good
>>>
>>> Reviewed-by: Rich Johnston <[hidden email]>
>>>
>>> Eric,
>>>
>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>
>> From: Satoru Takeuchi <[hidden email]>
>>
>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>
>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>
>> It does not modify src/Makefile and realpath is never compiled.
>
> Yep, whoops.  Merge error . . .?
>
>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Well, I don't think ./check will get very far with an undefined TEST_DEV or
> SCRATCH_DEV, but better this way, thanks.

I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
I forgot to specify $SCRATCH_DEV and found this problem.

Satoru


_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Eric Sandeen-3
On 11/19/12 10:30 PM, sat wrote:

> (2012/11/20 13:06), Eric Sandeen wrote:
>> On 11/18/12 9:26 PM, sat wrote:
>>> Hi Rich, Eric
>>>
>>> (2012/10/27 1:46), Rich Johnston wrote:
>>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>>> it'll fail to run several tests because our _require_scratch
>>>>> framework ultimately uses lstat not stat, and does not think
>>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>>> is a block device.  Sigh.
>>>>>
>>>>> Last try at this - just resolve any symlinked devicenames
>>>>> into their realpath(3) in common.config.
>>>>>
>>>>> This actually seems to work.
>>>>>
>>>>> Signed-off-by: Eric Sandeen <[hidden email]>
>>>>>
>>>>> ---
>>>>>
>>>>>
>>>>> diff --git a/common.config b/common.config
>>>>> index 926846b..e5b2483 100644
>>>>> --- a/common.config
>>>>> +++ b/common.config
>>>>
>>>> Looks good
>>>>
>>>> Reviewed-by: Rich Johnston <[hidden email]>
>>>>
>>>> Eric,
>>>>
>>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>>
>>> From: Satoru Takeuchi <[hidden email]>
>>>
>>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>>
>>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>>
>>> It does not modify src/Makefile and realpath is never compiled.
>>
>> Yep, whoops.  Merge error . . .?
>>
>>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>>
>> Well, I don't think ./check will get very far with an undefined TEST_DEV or
>> SCRATCH_DEV, but better this way, thanks.
>
> I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
> I forgot to specify $SCRATCH_DEV and found this problem.

Ah, right - yes, that's perfectly valid, sorry.  Not thinking straight :)

-Eric

> Satoru
>
>

_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Rich Johnston
On 11/19/2012 11:28 PM, Eric Sandeen wrote:

> On 11/19/12 10:30 PM, sat wrote:
>> (2012/11/20 13:06), Eric Sandeen wrote:
>>> On 11/18/12 9:26 PM, sat wrote:
>>>> Hi Rich, Eric
>>>>
>>>> (2012/10/27 1:46), Rich Johnston wrote:
>>>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>>>> it'll fail to run several tests because our _require_scratch
>>>>>> framework ultimately uses lstat not stat, and does not think
>>>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>>>> is a block device.  Sigh.
>>>>>>
>>>>>> Last try at this - just resolve any symlinked devicenames
>>>>>> into their realpath(3) in common.config.
>>>>>>
>>>>>> This actually seems to work.
>>>>>>
>>>>>> Signed-off-by: Eric Sandeen <[hidden email]>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>>
>>>>>> diff --git a/common.config b/common.config
>>>>>> index 926846b..e5b2483 100644
>>>>>> --- a/common.config
>>>>>> +++ b/common.config
>>>>>
>>>>> Looks good
>>>>>
>>>>> Reviewed-by: Rich Johnston <[hidden email]>
>>>>>
>>>>> Eric,
>>>>>
>>>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>>>
>>>> From: Satoru Takeuchi <[hidden email]>
>>>>
>>>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>>>
>>>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>>>
>>>> It does not modify src/Makefile and realpath is never compiled.
>>>
>>> Yep, whoops.  Merge error . . .?

Yes sorry my bad.

>>>
>>>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>>>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>>>
>>> Well, I don't think ./check will get very far with an undefined TEST_DEV or
>>> SCRATCH_DEV, but better this way, thanks.
>>
>> I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
>> I forgot to specify $SCRATCH_DEV and found this problem.
>
> Ah, right - yes, that's perfectly valid, sorry.  Not thinking straight :)
>
> -Eric

Eric, do you have time to correct these 2 errors or do want me submit a
patch?

>
>> Satoru
>>
>>
>


_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

Eric Sandeen-3
On Nov 20, 2012, at 7:53 AM, Rich Johnston <[hidden email]> wrote:

> On 11/19/2012 11:28 PM, Eric Sandeen wrote:
>> On 11/19/12 10:30 PM, sat wrote:
>>> (2012/11/20 13:06), Eric Sandeen wrote:
>>>> On 11/18/12 9:26 PM, sat wrote:
>>>>> Hi Rich, Eric
>>>>>
>>>>> (2012/10/27 1:46), Rich Johnston wrote:
>>>>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>>>>> it'll fail to run several tests because our _require_scratch
>>>>>>> framework ultimately uses lstat not stat, and does not think
>>>>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>>>>> is a block device.  Sigh.
>>>>>>>
>>>>>>> Last try at this - just resolve any symlinked devicenames
>>>>>>> into their realpath(3) in common.config.
>>>>>>>
>>>>>>> This actually seems to work.
>>>>>>>
>>>>>>> Signed-off-by: Eric Sandeen <[hidden email]>
>>>>>>>
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>> diff --git a/common.config b/common.config
>>>>>>> index 926846b..e5b2483 100644
>>>>>>> --- a/common.config
>>>>>>> +++ b/common.config
>>>>>>
>>>>>> Looks good
>>>>>>
>>>>>> Reviewed-by: Rich Johnston <[hidden email]>
>>>>>>
>>>>>> Eric,
>>>>>>
>>>>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>>>>
>>>>> From: Satoru Takeuchi <[hidden email]>
>>>>>
>>>>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>>>>
>>>>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>>>>
>>>>> It does not modify src/Makefile and realpath is never compiled.
>>>>
>>>> Yep, whoops.  Merge error . . .?
>
> Yes sorry my bad.
>
>>>>
>>>>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>>>>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>>>>
>>>> Well, I don't think ./check will get very far with an undefined TEST_DEV or
>>>> SCRATCH_DEV, but better this way, thanks.
>>>
>>> I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
>>> I forgot to specify $SCRATCH_DEV and found this problem.
>>
>> Ah, right - yes, that's perfectly valid, sorry.  Not thinking straight :)
>>
>> -Eric
>
> Eric, do you have time to correct these 2 errors or do want me submit a patch?
>
Satoru had submitted the patch and it has 2 reviews on list, just look up-thread.  :)

Eric

>>
>>> Satoru
>>>
>>>
>>
>
>

_______________________________________________
xfs mailing list
[hidden email]
http://oss.sgi.com/mailman/listinfo/xfs
Loading...